Strip AI-drafted wait stat content + legacy marker + drop Rule 21 (#215 D3)#266
Merged
Merged
Conversation
… 21 (#215 D3, framework marker, Joe's categorization refinements) D3: WaitStatsKnowledge Description / HowToFix text was AI-drafted without expert review. Joe flagged the SOS_SCHEDULER_YIELD fix text as misleading and asked that creative copy come from SQL Server experts, not AI. Stripped all Description and HowToFix content; kept the file structure and the ShowEffectiveLatency flag (structural, not creative). Entries are still emitted but the warning message now shows only the wait name, observed ms and wait count, and — for PAGEIOLATCH_* — effective latency. Erik / Joe fill in content over time; the pipeline is ready to render it when they do. BenefitScorer.EmitWaitStatWarnings now omits the description separator and sets ActionableFix to null when the entry has no HowToFix, so the renderers don't print empty "Fix:" prefixes. Framework marker (option a, flipped): PlanWarning + WarningResult grow an IsLegacy bool. Joe's preference: tag old rules so new ones don't need re-tagging when the rest get migrated. A LegacyWarningTypes set in PlanAnalyzer lists rules that haven't been folded into the benefit-scoring framework yet; MarkLegacyWarnings post-pass sets IsLegacy = true on matches. Renderers (web strip, HTML export, Avalonia plan + node warnings, TextFormatter statement + grouped operator paths) all show a "legacy" badge or " [legacy]" tag when set. Rule 21 (CTE referenced multiple times) removed per Joe's feedback — actual plans already show where time goes; statement-text pattern matching on CTE references is guessing. Removed the rule, its regex, the rule map entry, and DetectMultiReferenceCte helper. TextFormatter operator-warning benefit % now also uses the N1-except-100 formatter so grouped operator output is consistent with the rest of the UI. Version bump 1.7.6 -> 1.7.7. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Prior commit's Python patch script wrote LF line endings. This file is checked in with CRLF; restoring. No code change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Test plan
🤖 Generated with Claude Code