Runtime card refinements (#215 E7-E11)#270
Merged
Merged
Conversation
- E7: card title is "Predicted Runtime" for estimated plans ("Runtime" for
actual). Applied on HTML export, web viewer, and Avalonia (via new
RuntimeSummaryTitle x:Name binding).
- E8: used grant % > 100 is rendered as eff-bad (red) — an over-used grant
is the opposite of healthy, not green.
- E9: any operator in the plan that spilled to tempdb also forces the grant
tier to eff-warn at best, regardless of utilization %. A 60%-used grant
with a spilled sort underneath isn't "good".
- E10: spill indicator appended to the Memory/Used row when any operator
warning has a type ending in "Spill". Shows as "⚠ spill" (HTML + web use a
styled .spill-tag span; Avalonia uses plain text suffix).
- E11: Runtime box reordered to Joe's preferred layout —
Elapsed → CPU:Elapsed → DOP → CPU → Compile → Memory/Used → Optimization
→ CE Model → Cost
Avalonia keeps its extra rows (UDF, Threads, Cached plan size, Grant wait,
Early abort) slotted near logical neighbors. Cost moves from first to
last across all three surfaces. Also adds a CPU:Elapsed row to the Avalonia
panel (previously only on web and HTML).
New GetMemoryGrantColorClass / MemoryGrantColor helper centralizes the
tiering so the three surfaces stay consistent. HasSpillInTree /
HasSpillInPlanTree walks warnings looking for types that end with " Spill".
Version bump 1.7.8 -> 1.8.0.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Five Joe-feedback items on the Runtime card:
Version 1.7.8 → 1.8.0 (this is the first PR of a batch — subsequent PRs will stay at 1.8.0 for one bundled release).
🤖 Generated with Claude Code