Skip to content

Format Options dialog: PascalCase split + suppress spurious dirty state#284

Merged
erikdarlingdata merged 1 commit into
devfrom
chore/format-options-fixes
Apr 26, 2026
Merged

Format Options dialog: PascalCase split + suppress spurious dirty state#284
erikdarlingdata merged 1 commit into
devfrom
chore/format-options-fixes

Conversation

@erikdarlingdata
Copy link
Copy Markdown
Owner

Summary

  • The Parameter column showed raw PascalCase property names (e.g. MultilineInsertSourcesList); now space-split (Multiline Insert Sources List).
  • Closing the dialog without changes always prompted "unsaved changes" because TwoWay binding writes during DataGrid row virtualization fired PropertyChanged even for unchanged values. Setters now check equality first.

Test plan

  • Open Format Options, verify column reads with spaces between words
  • Open Format Options, immediately Close — dialog closes without prompt
  • Toggle a setting, Close — prompt appears as expected

🤖 Generated with Claude Code

…rious dirty state

- Show "Keyword Casing" instead of "KeywordCasing" in the Parameter column
- Row setters were firing PropertyChanged unconditionally; TwoWay bindings on
  ToggleSwitch / ComboBox write the bound value back during DataGrid row
  materialization (post-virtualization), tripping the dirty flag without any
  user action. Setters now compare and short-circuit when the value is unchanged.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@erikdarlingdata erikdarlingdata merged commit 2ce0a61 into dev Apr 26, 2026
@erikdarlingdata erikdarlingdata deleted the chore/format-options-fixes branch April 26, 2026 00:42
@erikdarlingdata erikdarlingdata mentioned this pull request Apr 27, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant