Skip to content

Clean up two warnings from PR #336 #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 1 commit into from
May 18, 2026
Merged

Clean up two warnings from PR #336 #339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/PlanViewer.App/Controls/QueryStoreHistoryControl.axaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ public partial class QueryStoreHistoryControl : UserControl

// Legend state
private bool _legendExpanded;
private bool _suppressGridSelectionEvent;
private bool _isLoadingPlan;
private string _dataSummaryText = "";

Expand Down Expand Up @@ -793,7 +792,7 @@ private void HighlightGridRows()
// (which would wipe sort state and scroll position)
foreach (var row in HistoryDataGrid.GetVisualDescendants().OfType<DataGridRow>())
{
var idx = row.GetIndex();
var idx = row.Index;
row.Background = _selectedRowIndices.Contains(idx)
? new SolidColorBrush(Avalonia.Media.Color.FromArgb(60, 79, 195, 247))
: Brushes.Transparent;
Expand Down Expand Up @@ -829,8 +828,6 @@ private void OnHighlightLoadingRow(object? sender, DataGridRowEventArgs e)

private void HistoryDataGrid_SelectionChanged(object? sender, SelectionChangedEventArgs e)
{
if (_suppressGridSelectionEvent) return;

_selectedRowIndices.Clear();
if (HistoryDataGrid.SelectedItems != null)
{
Expand Down
Loading