Skip to content

Fix warnings gap in properties panel (#29) #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 1 commit into from
Mar 5, 2026
Merged

Fix warnings gap in properties panel (#29) #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 48 additions & 4 deletions src/PlanViewer.App/Controls/PlanViewerControl.axaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1465,7 +1465,7 @@ private void ShowPropertiesPanel(PlanNode node)
// === Plan-Level Warnings ===
if (s.PlanWarnings.Count > 0)
{
AddPropertySection("Plan Warnings");
var planWarningsPanel = new StackPanel();
foreach (var w in s.PlanWarnings)
{
var warnColor = w.Severity == PlanWarningSeverity.Critical ? "#E57373"
Expand All @@ -1486,8 +1486,30 @@ private void ShowPropertiesPanel(PlanNode node)
TextWrapping = TextWrapping.Wrap,
Margin = new Thickness(16, 0, 0, 0)
});
(_currentPropertySection ?? PropertiesContent).Children.Add(warnPanel);
planWarningsPanel.Children.Add(warnPanel);
}

var planWarningsExpander = new Expander
{
IsExpanded = true,
Header = new TextBlock
{
Text = "Plan Warnings",
FontWeight = FontWeight.SemiBold,
FontSize = 11,
Foreground = SectionHeaderBrush
},
Content = planWarningsPanel,
Margin = new Thickness(0, 2, 0, 0),
Padding = new Thickness(0),
Foreground = SectionHeaderBrush,
Background = new SolidColorBrush(Color.FromArgb(0x18, 0x4F, 0xA3, 0xFF)),
BorderBrush = PropSeparatorBrush,
BorderThickness = new Thickness(0, 0, 0, 1),
HorizontalAlignment = HorizontalAlignment.Stretch,
HorizontalContentAlignment = HorizontalAlignment.Stretch
};
PropertiesContent.Children.Add(planWarningsExpander);
}

// === Missing Indexes ===
Expand All @@ -1506,7 +1528,7 @@ private void ShowPropertiesPanel(PlanNode node)
// === Warnings ===
if (node.HasWarnings)
{
AddPropertySection("Warnings");
var warningsPanel = new StackPanel();
foreach (var w in node.Warnings)
{
var warnColor = w.Severity == PlanWarningSeverity.Critical ? "#E57373"
Expand All @@ -1527,8 +1549,30 @@ private void ShowPropertiesPanel(PlanNode node)
TextWrapping = TextWrapping.Wrap,
Margin = new Thickness(16, 0, 0, 0)
});
PropertiesContent.Children.Add(warnPanel);
warningsPanel.Children.Add(warnPanel);
}

var warningsExpander = new Expander
{
IsExpanded = true,
Header = new TextBlock
{
Text = "Warnings",
FontWeight = FontWeight.SemiBold,
FontSize = 11,
Foreground = SectionHeaderBrush
},
Content = warningsPanel,
Margin = new Thickness(0, 2, 0, 0),
Padding = new Thickness(0),
Foreground = SectionHeaderBrush,
Background = new SolidColorBrush(Color.FromArgb(0x18, 0x4F, 0xA3, 0xFF)),
BorderBrush = PropSeparatorBrush,
BorderThickness = new Thickness(0, 0, 0, 1),
HorizontalAlignment = HorizontalAlignment.Stretch,
HorizontalContentAlignment = HorizontalAlignment.Stretch
};
PropertiesContent.Children.Add(warningsExpander);
}

// Show the panel
Expand Down
Loading