Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/PlanViewer.App/Controls/PlanViewerControl.axaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1783,8 +1783,9 @@ private object BuildNodeTooltipContent(PlanNode node, List<PlanWarning>? allWarn
|| node.ActualRebinds > 0 || node.ActualRewinds > 0)
{
AddTooltipSection(stack, "Rebinds / Rewinds");
if (node.EstimateRebinds > 0) AddTooltipRow(stack, "Est. Rebinds", $"{node.EstimateRebinds:N1}");
if (node.EstimateRewinds > 0) AddTooltipRow(stack, "Est. Rewinds", $"{node.EstimateRewinds:N1}");
// Always show both estimated values when section is visible
AddTooltipRow(stack, "Est. Rebinds", $"{node.EstimateRebinds:N1}");
AddTooltipRow(stack, "Est. Rewinds", $"{node.EstimateRewinds:N1}");
if (node.ActualRebinds > 0) AddTooltipRow(stack, "Actual Rebinds", $"{node.ActualRebinds:N0}");
if (node.ActualRewinds > 0) AddTooltipRow(stack, "Actual Rewinds", $"{node.ActualRewinds:N0}");
}
Expand Down
4 changes: 2 additions & 2 deletions src/PlanViewer.App/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
<key>CFBundleExecutable</key>
<string>PlanViewer.App</string>
<key>CFBundleVersion</key>
<string>0.9.0</string>
<string>1.0.0</string>
<key>CFBundleShortVersionString</key>
<string>0.9.0</string>
<string>1.0.0</string>
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>NSHumanReadableCopyright</key>
Expand Down
2 changes: 1 addition & 1 deletion src/PlanViewer.App/PlanViewer.App.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<Nullable>enable</Nullable>
<ApplicationManifest>app.manifest</ApplicationManifest>
<AvaloniaUseCompiledBindingsByDefault>true</AvaloniaUseCompiledBindingsByDefault>
<Version>0.9.0</Version>
<Version>1.0.0</Version>
<Authors>Erik Darling</Authors>
<Company>Darling Data LLC</Company>
<Product>Performance Studio</Product>
Expand Down
4 changes: 3 additions & 1 deletion src/PlanViewer.App/Services/AdviceContentBuilder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,9 @@ public static StackPanel Build(string content)
}

// Expensive operator timing lines: "4,616ms CPU (61%), 586ms elapsed (62%)"
if (trimmed.Contains("ms CPU") || trimmed.Contains("ms elapsed"))
// Must start with a digit to avoid catching "Runtime: 1,234ms elapsed, 1,200ms CPU"
if ((trimmed.Contains("ms CPU") || trimmed.Contains("ms elapsed"))
&& trimmed.Length > 0 && char.IsDigit(trimmed[0]))
{
panel.Children.Add(CreateOperatorTimingLine(trimmed));
continue;
Expand Down
2 changes: 1 addition & 1 deletion src/PlanViewer.Cli/PlanViewer.Cli.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<Nullable>enable</Nullable>
<RootNamespace>PlanViewer.Cli</RootNamespace>
<AssemblyName>planview</AssemblyName>
<Version>0.9.0</Version>
<Version>1.0.0</Version>
<Authors>Erik Darling</Authors>
<Company>Darling Data LLC</Company>
<Product>Performance Studio</Product>
Expand Down
16 changes: 16 additions & 0 deletions tests/PlanViewer.Core.Tests/PlanAnalyzerTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -743,4 +743,20 @@ public void ParallelSkew_DetectedInSkewedPlan()
}
return null;
}

// ---------------------------------------------------------------
// NoJoinPredicate: verify it flows through to TextFormatter output
// ---------------------------------------------------------------

[Fact]
public void NoJoinPredicate_AppearsInTextFormatterOutput()
{
var plan = PlanTestHelper.LoadAndAnalyze("missing-join-predicate.sqlplan");
var analysis = PlanViewer.Core.Output.ResultMapper.Map(plan, "file");
var text = PlanViewer.Core.Output.TextFormatter.Format(analysis);

Assert.Contains("[Warning]", text);
Assert.Contains("No Join Predicate", text);
Assert.Contains("often misleading", text);
}
}
Binary file not shown.
Loading