Plan analyzer improvements#65
Merged
Merged
Conversation
…ort, key lookup severity - Batch mode sort skew: downgrade to Info with "by design" note (unless feeding Window Aggregate) - Root node tooltip now includes statement-level PlanWarnings (e.g., Optimize For Unknown) - OPTIMIZE FOR UNKNOWN: distinguish from OPTION(RECOMPILE) in parameter annotations - Key Lookup with predicate: upgrade from Warning to Critical - Table variable: add statement-level warnings for stats + modification serial execution (Critical) - Top N Sort: parse <TopSort> XML element, set LogicalOp to "Top N Sort" - Rule 24: broaden to any Top/Top N Sort above scan (Critical when on NL inner side) - Fix IsOrExpansionChain to match normalized "Top N Sort" LogicalOp - Update Rule 22 test for new statement-level warnings Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<TopSort>XML element, display as "Sort (Top N Sort)" matching SSMSTest plan
🤖 Generated with Claude Code