forked from StackOverflowMATLABchat/legtools
-
Notifications
You must be signed in to change notification settings - Fork 0
Pull rc into master #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
help legtools.append now is easier to read, easier to understand and less technical.
MATLAB R2016b introduces a new character data type: string. This commit adds support for this class while retaining compatibility with older MATLAB versions.
The append and adddummy methods both implement identical validation of the newStrings input argument. This commit moves this validation to the strcheck method.
The append method contains a bug when it appends to a legend that has been permuted previously or if the parent axes children have been sorted differently after the legend has been modified. Append assumes the parent axes children are in the same order as the current legend PlotChildren, which may not be the case. For example, after permuting the legend entries, this order may have changed.
The adddummy method now supports various plotParams formats. Specifying no or empty plotParams is also supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.