Skip to content

Make host and port configurable#8

Merged
erikjohnston merged 4 commits into
erikjohnston:masterfrom
MadLittleMods:madlittlemods/configurable-host-port
Sep 1, 2022
Merged

Make host and port configurable#8
erikjohnston merged 4 commits into
erikjohnston:masterfrom
MadLittleMods:madlittlemods/configurable-host-port

Conversation

@MadLittleMods
Copy link
Copy Markdown
Contributor

@MadLittleMods MadLittleMods commented Aug 17, 2022

Make host and port configurable

reporter = Reporter(config={"agent_host_name": "some-host", "agent_port": 9999})

Fixes matrix-org/synapse#13399 (comment)

Dev notes

$ source /Users/eric/Documents/github/element/synapse/.venv/bin/activate
$ pip install maturin
# builds the crate and installs it as a python module directly in the current virtualenv. Note that while maturin develop is faster, it doesn't support all the feature that running pip install after maturin build supports.
$ maturin develop

# Sends spans over to your local Jaeger instance
$ python test.py

References:

Comment thread pyproject.toml

# Optional Dependencies
# ---------------------
objgraph = { version = ">=3.5.0", optional = true }
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is part of test.py 🤷

Comment thread src/lib.rs
@MadLittleMods MadLittleMods marked this pull request as ready for review August 17, 2022 05:18
@erikjohnston
Copy link
Copy Markdown
Owner

deref on an immutable reference

The check looks to be spurious, and caused by rust-lang/rust-clippy#8971

Copy link
Copy Markdown
Owner

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woop

Comment thread src/lib.rs Outdated
Comment thread src/lib.rs Outdated
@erikjohnston erikjohnston merged commit 7e92385 into erikjohnston:master Sep 1, 2022
@MadLittleMods
Copy link
Copy Markdown
Contributor Author

Thanks for the review and merge @erikjohnston 🐻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants