-
Notifications
You must be signed in to change notification settings - Fork 631
Add some slack functionality #1189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some slack functionality #1189
Conversation
e1a0cbe to
ac078e2
Compare
ac078e2 to
1714efa
Compare
GenPage
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would split it this PR. Also, if we need to add a feature that can be supported by other backens, we need to add it in the API of Errbot and not only on the Slack API.
|
So I like the idea and I would implement it fully in Errbot then:
The last thing: Creates a new method to transform an event into a Message <- is this just an internal thing? |
|
That's reasonable. I can help assist, especially with the API portions
3 & 4. Sounds good 👍 As for the new method for Slack event message processing, This is internal Slack refactor from what I can tell so that the new method is available to the update/delete methods to call on return. |
gbin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you split this PR into independent ones for each feature? Thank you.
|
@TheJokersThief Are you able to split the work into multiple PRs? |
|
Hey! Sorry, I completely missed the notification for this. I can split the work into multiple PRs as I get time, that's no problem :) With regards your point 1 in the previous message, @GenPage, one of the benefits of slack cards is that they can stack in a single message. For us, we use them to track the progress of a long-running set of tasks. Having all the cards in one message keeps things clean and makes it easy to reference later. |
|
I've added 4 PRs to get some of the easier recommended PRs out of the way :) |
|
I'm closing this as its been broken up into multiple PRs. |
I submitted an issue/feature suggestion (#1181) a while ago asking about interest in adding some slack functionality.
This pull request:
eventinto aMessageThese are things we've found useful at HostedGraphite for our ChatOps bot.
I hope this is okay but if it doesn't feel like it would fit in with the bot overall, I totally understand 😊 I've really enjoyed working with the codebase and it's made development much easier for us so I was hoping to contribute some of our home-grown improvements upstream.
Sidenote: I tried running the tox tests on OSX but they ran into an error about being unable to create a new thread and I assume codestyle tests that fail but aren't related to this PR are okay.