Adds ability to divert all to private or thread#1528
Merged
sijis merged 9 commits intoerrbotio:masterfrom Oct 6, 2021
Merged
Conversation
3 tasks
This adds a `__magic_all__` option that you can add to either the DIVERT_TO_THREAD or DIVERT_TO_PRIVATE configuration options instead of adding each command individually.
Two underscores looked great and more like the python way to do things until I saw that some fonts were putting the two underscores into a single underscore, and that would be confusing to end-users if the docs said the same thing. By using a single underscore and using the `'str' in str` method both double-underscore and single-underscore values will be acceptable.
sijis
force-pushed
the
iamkirkbater-master-divert-private
branch
from
c355647 to
aa0f53d
Compare
sijis
added a commit
that referenced
this pull request
Jun 11, 2022
* Adds ability to divert all to private or thread This adds a `__magic_all__` option that you can add to either the DIVERT_TO_THREAD or DIVERT_TO_PRIVATE configuration options instead of adding each command individually. * Only use one underscore Two underscores looked great and more like the python way to do things until I saw that some fonts were putting the two underscores into a single underscore, and that would be confusing to end-users if the docs said the same thing. By using a single underscore and using the `'str' in str` method both double-underscore and single-underscore values will be acceptable. * Lint fix * style: lint * fix: rename magic string to ALL_COMMANDS * docs: add magic string to config-template * docs: Add info to CHANGES * fix: comment typo * test: add initial basic check Co-authored-by: Kirk Bater <kirk.bater@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
ALL_COMMANDSoption that you can add to either theDIVERT_TO_THREADorDIVERT_TO_PRIVATEconfiguration options instead ofadding each command individually.
To Do:
core.pyhas much there to begin withRebased original ticket #1371, to sync up recent changes.