Skip to content

Remove unsupport argument reconnection_interval from irc backend.#1568

Merged
sijis merged 1 commit intoerrbotio:masterfrom
nzlosh:irc_v20_fix
May 4, 2022
Merged

Remove unsupport argument reconnection_interval from irc backend.#1568
sijis merged 1 commit intoerrbotio:masterfrom
nzlosh:irc_v20_fix

Conversation

@nzlosh
Copy link
Copy Markdown
Contributor

@nzlosh nzlosh commented Apr 22, 2022

Fixes #1566

@sijis
Copy link
Copy Markdown
Contributor

sijis commented Apr 23, 2022

So with this, I would need to adjust the pinned dependency for it in

errbot/setup.py

Line 112 in 89ccd00

"irc==20.0.0",
?

@nzlosh
Copy link
Copy Markdown
Contributor Author

nzlosh commented Apr 23, 2022

Sorry, I didn't explain this PR well. This patch is to make the irc backend compatible with irc==20.0.0 which removed reconnection_interval as an argument. https://github.com/jaraco/irc/blob/main/CHANGES.rst#v2000. So there's no need to adjust pinning, as it's already set to v20

@sijis sijis changed the title Fixes #1566 Remove unsupport argument reconnection_interval from irc backend. Remove unsupport argument reconnection_interval from irc backend. May 4, 2022
@sijis sijis merged commit 9a6287b into errbotio:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IRC backend doesn't work

2 participants