Skip to content

Fix forward references in XMPP backend#1580

Merged
sijis merged 3 commits intoerrbotio:masterfrom
ariep:1578-fix-forward-references
Jun 22, 2022
Merged

Fix forward references in XMPP backend#1580
sijis merged 3 commits intoerrbotio:masterfrom
ariep:1578-fix-forward-references

Conversation

@ariep
Copy link
Copy Markdown
Contributor

@ariep ariep commented Jun 19, 2022

Fixes #1578 .

@sijis
Copy link
Copy Markdown
Contributor

sijis commented Jun 20, 2022

@ariep Thank you for the fix. Please run isort on the file to fix the linting issue. Also, if you could include a note in CHANGES.rst, that would be helpful too!

@sijis sijis force-pushed the 1578-fix-forward-references branch from 3fa3489 to f7a5061 Compare June 22, 2022 05:37
@sijis sijis merged commit 7d38085 into errbotio:master Jun 22, 2022
@sijis
Copy link
Copy Markdown
Contributor

sijis commented Jun 22, 2022

Thank you!

sijis pushed a commit to sijis/errbot that referenced this pull request Jan 1, 2024
* Fix forward references in XMPP backend

* isort imports of xmpp backend

* Note fix to xmpp backend in CHANGES
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Forward reference fails in type annotations

2 participants