Deprecate the SENTRY_TRANSPORT option#1605
Merged
sijis merged 2 commits intoerrbotio:masterfrom Jan 22, 2023
Merged
Conversation
Contributor
|
@browniebroke You'll have to rebase. Also, could you add a note in |
Contributor
Author
|
Sure, will do! |
browniebroke
force-pushed
the
feat/deprecate-sentry-transport
branch
from
f88c43d to
e819f38
Compare
Contributor
Author
|
All done I think. |
sijis
force-pushed
the
feat/deprecate-sentry-transport
branch
from
5a67d47 to
996e436
Compare
sijis
pushed a commit
to sijis/errbot
that referenced
this pull request
Jan 1, 2024
* fix: deprecate the SENTRY_TRANSPORT option * docs: add info to CHANGES
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #1597. Due to the addition of the
SENTRY_OPTIONSsetting, we no longer need a custom one for the transport option.In the newer client
sentry-sdk, the transport option has been simplified compared to the old Sentry client (Raven) which was providing multiple transport classes.The SDK only ships with the base abstract
Transportclass and the defaultHttpTransportclass as can be seen here.