Restore Python 3.8/3.9 compatibility for unit-test collection#19
Merged
Restore Python 3.8/3.9 compatibility for unit-test collection#19
Conversation
Co-authored-by: erseco <1876752+erseco@users.noreply.github.com>
Co-authored-by: erseco <1876752+erseco@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add CI coverage for multiple supported Python and Moodle versions
Expand CI coverage across supported Python versions and representative Moodle versions
Mar 16, 2026
Co-authored-by: erseco <1876752+erseco@users.noreply.github.com>
Copilot
AI
changed the title
Expand CI coverage across supported Python versions and representative Moodle versions
Restore Python 3.8/3.9 compatibility for unit-test collection
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make test-unitwas failing on Python 3.8 and 3.9 duringtests/conftest.pyimport. The failure came from runtime evaluation of newer type-hint syntax in modules pulled in during unit-test collection.Unit test collection
py_moodleimports from/home/runner/work/python-moodle/python-moodle/tests/conftest.pytests/unitcollection independent from the integration stackPython 3.8/3.9 compatibility
from __future__ import annotationsto the modules reached by smoke tests:/home/runner/work/python-moodle/python-moodle/src/py_moodle/session.py/home/runner/work/python-moodle/python-moodle/src/py_moodle/course.py/home/runner/work/python-moodle/python-moodle/src/py_moodle/folder.py/home/runner/work/python-moodle/python-moodle/src/py_moodle/module.pydict[str, ...]andstr | Nonefrom being evaluated at import time on older supported interpretersEffect on CI
test-unitpath for the supported Python matrix without changing integration-test behaviorExample of the compatibility change:
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.