Potential fix for code scanning alert no. 1: Workflow does not contain permissions#4
Merged
Potential fix for code scanning alert no. 1: Workflow does not contain permissions#4
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/erseco/python-moodle/security/code-scanning/1
To fix the problem, we should explicitly set the
permissionsblock in the workflow. The best practice is to set the most restrictive permissions at the workflow level (e.g.,contents: read), and then override them at the job or step level if more permissions are needed. In this workflow, only the "Deploy to GitHub Pages" step (within thebuildjob) requirescontents: writeto push to thegh-pagesbranch. Therefore, we should:permissions: contents: readat the top level of the workflow (applies to all jobs by default).permissions: contents: writeto thebuildjob, since the deployment step needs to push to the repository.Alternatively, if you want to be even more restrictive, you could split the deployment into a separate job with elevated permissions, but for this workflow, setting it at the job level is sufficient.
Files/regions to change:
permissionsblock at the top level (aftername:and beforeon:).permissionsblock at thebuildjob level if you want to be explicit.Methods/imports/definitions needed:
Suggested fixes powered by Copilot Autofix. Review carefully before merging.