Validate upload repository ID and adjust test#6
Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation to ensure the detected upload repository ID is a positive integer and relaxes the corresponding test to accept any positive ID instead of requiring a specific value.
- Adds validation in
detect_upload_repoto check that the repository ID is positive - Updates the test to verify the ID is positive rather than checking for a specific value (5)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/py_moodle/draftfile.py | Adds validation to ensure repository ID is positive before returning |
| tests/test_draftfile.py | Relaxes test assertion to check for any positive integer instead of specific value |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detect_upload_repotest to accept any positive IDTesting
make lintmake test-staginghttps://chatgpt.com/codex/tasks/task_e_6891a06ad8ec8322a09a17985e01618b