fix: add HotWaterInUse model, null nextTimeBlock guard, and meter readings URI#159
Open
banter240 wants to merge 1 commit intoerwindouna:mainfrom
Open
fix: add HotWaterInUse model, null nextTimeBlock guard, and meter readings URI#159banter240 wants to merge 1 commit intoerwindouna:mainfrom
banter240 wants to merge 1 commit intoerwindouna:mainfrom
Conversation
wmalgadey
added
the
bugfix
Collaborator
|
@banter240 please fix the linting issues. FYI: we have a devcontainer for executing the preCommit hooks, if you like. It would fix those errors right away |
…dings URI
- Add HotWaterInUse dataclass to models_v3.py and expose it as
hot_water_in_use field on ActivityDataPoints (API returns hotWaterInUse
for hot water zones, which was silently dropped during deserialization)
- Guard against null nextTimeBlock in ZoneState.__pre_deserialize__ to
prevent deserialization errors when API returns null instead of an object
- Fix set_meter_readings to include the required URI path
(homes/{home_id}/meterReadings was missing, causing requests to hit the
wrong endpoint)
banter240
force-pushed
the
fix/zone-state-and-meter-readings
branch
from
d92f587 to
80fee09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes