Make it possible to override gap_element#13
Open
reynoldsnlp wants to merge 1 commit intoeseraygun:masterfrom
Open
Make it possible to override gap_element#13reynoldsnlp wants to merge 1 commit intoeseraygun:masterfrom
reynoldsnlp wants to merge 1 commit intoeseraygun:masterfrom
Conversation
`'-'` as a gap element doesn't work for my project. Currently, I am doing the following, but it seems pretty hack-ish: ```python import alignment alignment.vocabulary.GAP_ELEMENT = '∅' ``` This pull request would make it possible to define these values when initializing the `Vocabulary`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'-'as a gap element doesn't work for my project.Currently, I am doing the following, but it seems pretty hack-ish:
This pull request would make it possible to define these values when initializing the
Vocabulary, like thisVocabulary(gap_element='∅').I don't understand why
GAP_ELEMENTis defined in a different file. Maybe you don't need the constants at all, and just have defaults in the__init__().