feature(script): add nextcloud#85
Conversation
|
Thanks for the PR. Going forward please use dev as your base branch. We will update our contribution docs to that end and review this right away! |
f382f2b to
80365f1
Compare
|
Thanks for the feedback @jerodfritz, I have rebased the commits on the dev branch. Edit:
|
|
Do you want me to prepare the addition to the curated scripts already as well? Or is that something you'll do after reviewing the PR? |
|
That index generation should be moved to our CI. Don’t worry about it for now. We are addressing it as part of a larger apps overhaul that is in progress.
|
2b913c1 to
c878ba4
Compare
it doesn't provide any value out-of-the-box
c878ba4 to
76db241
Compare
|
@jerodfritz I see that you added a Nextcloud script to the repository now. |
|
Hey @SimJoSt . Yes, the PR is still relevant. The Nextcloud script that’s now in the repo is based on the one you originally provided, with some adjustments made to align it with our v3 structure and conventions. We didn’t originally have this on our immediate roadmap, but your initial work was solid and prompted us to include it. Because there were a few required changes and some timing overlap with the backend changes we batched those updates together. I’ll be merging this PR with your contributions included so your attribution remains intact soon. Thank you for the effort and followup! |
consolidating contributions from @SimJoSt @acknologia and @Mkayyyyyy
a20e7ef to
9a03041
Compare
|
@jerodfritz thanks for the merge and feedback, especially during the holidays. Sounds good! |
I like the way HexOS curated apps create and use nicely structured datasets, instead of hidden ones. Especially, with apps where the stored data might be good to access directly as well.
Nextcloud was the next app I wanted to install that way, so I created the custom install script myself.
I am hoping for constructive feedback, as I don't know the best practices when it comes to a few things.
For example, a good value for
$RANDOM_STRING(). In the examples and in the existing scripts, there is no clear favourite.Also with the network config. Does it need to be set at all, if the TrueNAS template contains a default?
Or why are the ports set to different values in the existing HexOS install scripts, that diverge from the TrueNAS default.
Known Issues
APT Packages
As v2 of HexOS' install scripts doesn't support the question type
listwithenumyet, it is not possible to let users choose the desired packages.As HexOS scripts are supposed to help non-technical users, I set all available options as a default to allow for maximum flexibility and features, even though the TrueNAS default is none.
Tesseract languages
Same issue as with APT packages.
A sane default for all users is difficult to set.
Cron
Installing fails when Cron is enabled. This is not an issue with HexOS or this script, but a general bug in the TrueNAS Nextcloud app:: https://ixsystems.atlassian.net/browse/NAS-138653