Skip to content

feature(script): add nextcloud#85

Merged
jerodfritz merged 8 commits intoeshtek:devfrom
SimJoSt:feature/nextcloud
Dec 28, 2025
Merged

feature(script): add nextcloud#85
jerodfritz merged 8 commits intoeshtek:devfrom
SimJoSt:feature/nextcloud

Conversation

@SimJoSt
Copy link
Copy Markdown
Contributor

@SimJoSt SimJoSt commented Nov 21, 2025

I like the way HexOS curated apps create and use nicely structured datasets, instead of hidden ones. Especially, with apps where the stored data might be good to access directly as well.

Nextcloud was the next app I wanted to install that way, so I created the custom install script myself.
I am hoping for constructive feedback, as I don't know the best practices when it comes to a few things.

For example, a good value for $RANDOM_STRING(). In the examples and in the existing scripts, there is no clear favourite.

Also with the network config. Does it need to be set at all, if the TrueNAS template contains a default?
Or why are the ports set to different values in the existing HexOS install scripts, that diverge from the TrueNAS default.

Known Issues

APT Packages

As v2 of HexOS' install scripts doesn't support the question type list with enum yet, it is not possible to let users choose the desired packages.
As HexOS scripts are supposed to help non-technical users, I set all available options as a default to allow for maximum flexibility and features, even though the TrueNAS default is none.

Tesseract languages

Same issue as with APT packages.
A sane default for all users is difficult to set.

Cron

Installing fails when Cron is enabled. This is not an issue with HexOS or this script, but a general bug in the TrueNAS Nextcloud app:: https://ixsystems.atlassian.net/browse/NAS-138653

@jerodfritz
Copy link
Copy Markdown
Contributor

Thanks for the PR.

Going forward please use dev as your base branch.

We will update our contribution docs to that end and review this right away!

@acknologia acknologia changed the base branch from main to dev November 21, 2025 23:48
@SimJoSt
Copy link
Copy Markdown
Contributor Author

SimJoSt commented Nov 22, 2025

Thanks for the feedback @jerodfritz, I have rebased the commits on the dev branch.
I'll raise some questions on the v2 format in the forum, for a proper discussion on some points.

Edit:

@SimJoSt
Copy link
Copy Markdown
Contributor Author

SimJoSt commented Nov 22, 2025

Do you want me to prepare the addition to the curated scripts already as well? Or is that something you'll do after reviewing the PR?
I noticed the dev branch is behind the main branch regarding this file:

@jerodfritz
Copy link
Copy Markdown
Contributor

jerodfritz commented Nov 22, 2025 via email

@SimJoSt SimJoSt force-pushed the feature/nextcloud branch 4 times, most recently from 2b913c1 to c878ba4 Compare November 23, 2025 03:01
@SimJoSt
Copy link
Copy Markdown
Contributor Author

SimJoSt commented Dec 28, 2025

@jerodfritz I see that you added a Nextcloud script to the repository now.
What is the plan for this PR? Is it still relevant?
Did you base the script on the one I provided? Or did you create yours from scratch?

@jerodfritz
Copy link
Copy Markdown
Contributor

Hey @SimJoSt . Yes, the PR is still relevant. The Nextcloud script that’s now in the repo is based on the one you originally provided, with some adjustments made to align it with our v3 structure and conventions.

We didn’t originally have this on our immediate roadmap, but your initial work was solid and prompted us to include it. Because there were a few required changes and some timing overlap with the backend changes we batched those updates together. I’ll be merging this PR with your contributions included so your attribution remains intact soon.

Thank you for the effort and followup!

consolidating contributions from @SimJoSt @acknologia and @Mkayyyyyy
@jerodfritz jerodfritz merged commit 4942494 into eshtek:dev Dec 28, 2025
@SimJoSt
Copy link
Copy Markdown
Contributor Author

SimJoSt commented Dec 29, 2025

@jerodfritz thanks for the merge and feedback, especially during the holidays. Sounds good!
I wanted to make sure, that the work I put into contributions are worth the time and effort before I work on the next ones.
With the feedback I got in the forum/hub on some best practices, I should be able to continue putting together more scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants