Skip to content

Added missing bind_dev getter and setter.#1419

Merged
bmah888 merged 2 commits intoesnet:masterfrom
WatcherOfTheSkies:master
Nov 22, 2022
Merged

Added missing bind_dev getter and setter.#1419
bmah888 merged 2 commits intoesnet:masterfrom
WatcherOfTheSkies:master

Conversation

@WatcherOfTheSkies
Copy link
Copy Markdown
Contributor

PLEASE NOTE the following text from the iperf3 license. Submitting a
pull request to the iperf3 repository constitutes "[making]
Enhancements available...publicly":

You are under no obligation whatsoever to provide any bug fixes, patches, or
upgrades to the features, functionality or performance of the source code
("Enhancements") to anyone; however, if you choose to make your Enhancements
available either publicly, or directly to Lawrence Berkeley National
Laboratory, without imposing a separate written license agreement for such
Enhancements, then you hereby grant the following license: a non-exclusive,
royalty-free perpetual license to install, use, modify, prepare derivative
works, incorporate into other computer software, distribute, and sublicense
such enhancements or derivative works thereof, in binary and source code form.

The complete iperf3 license is available in the LICENSE file in the
top directory of the iperf3 source tree.

  • Applies to master (and was meant for V3.11/V3.12)

  • Issues fixed (if any): Allows iperf API users to get/set the bind device. e.g. wwan0

  • Brief description of code changes (suitable for use as a commit message):
    Added missing bind_dev getter and setter.

@WatcherOfTheSkies
Copy link
Copy Markdown
Contributor Author

Maybe the setter should have been:
const char *bnd_dev
(sorry!)

@bmah888 bmah888 added the bug label Nov 22, 2022
@bmah888
Copy link
Copy Markdown
Contributor

bmah888 commented Nov 22, 2022

Thanks for the PR! This fixes a buglet that I introduced in #1097 by not adding the proper function declarations to src/iperf_api.h.

@bmah888 bmah888 self-assigned this Nov 22, 2022
@bmah888 bmah888 self-requested a review November 22, 2022 18:48
Copy link
Copy Markdown
Contributor

@bmah888 bmah888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! It'd also be good to get the libiperf.3 manual page in sync with respect to const correctness, but there are actually several places where we need to fix this.

@bmah888 bmah888 merged commit e33fddc into esnet:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants