Added missing bind_dev getter and setter.#1419
Merged
bmah888 merged 2 commits intoesnet:masterfrom Nov 22, 2022
Merged
Conversation
Contributor
Author
|
Maybe the setter should have been: |
Contributor
|
Thanks for the PR! This fixes a buglet that I introduced in #1097 by not adding the proper function declarations to |
bmah888
approved these changes
Nov 22, 2022
Contributor
bmah888
left a comment
There was a problem hiding this comment.
Looks good, thanks! It'd also be good to get the libiperf.3 manual page in sync with respect to const correctness, but there are actually several places where we need to fix this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE NOTE the following text from the iperf3 license. Submitting a
pull request to the iperf3 repository constitutes "[making]
Enhancements available...publicly":
The complete iperf3 license is available in the
LICENSEfile in thetop directory of the iperf3 source tree.
Applies to master (and was meant for V3.11/V3.12)
Issues fixed (if any): Allows iperf API users to get/set the bind device. e.g. wwan0
Brief description of code changes (suitable for use as a commit message):
Added missing bind_dev getter and setter.