-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix build with gcc-15 #1805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix build with gcc-15 #1805
Conversation
|
Thanks for the PR, we'll take a look! |
…anced per PR esnet#1805 (with rebase)
…anced per PR esnet#1805 (with rebase)
bmah888
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good, although my ability to test this is limited. Per #1838 (comment) would you know if this is the same fix that was applied to iperf 3.18-2 in the Debian package repository?
…anced per PR #1805 (with rebase)
|
I can test it. current master will fail with gcc 15 https://github.com/userdocs/iperf3-static-test/actions/runs/14755488675 This patch branch does not - https://github.com/userdocs/iperf3-static-test/actions/runs/14755738953/job/41423407651 |
Perfect, thanks the help @userdocs! |
bmah888
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Just to confirm it built fine on master with gcc15 https://github.com/userdocs/iperf3-static-test/actions/runs/14802833500 |
|
@userdocs Thanks for the confirmation! |
heitbaum is fine :-) as the LE distro packing lead, the team thought Mr.Bump suited, so the emoji stuck :-) |
PLEASE NOTE the following text from the iperf3 license. Submitting a
pull request to the iperf3 repository constitutes "[making]
Enhancements available...publicly":
The complete iperf3 license is available in the
LICENSEfile in thetop directory of the iperf3 source tree.
Version of iperf3 (or development branch, such as
masteror3.1-STABLE) to which this pull request applies: master and 3.17.1Issues fixed (if any): compile with gcc-15
Brief description of code changes (suitable for use as a commit message): update declarations to include types as required by gcc-15 and -std=c23