Skip to content

Conversation

@heitbaum
Copy link
Contributor

@heitbaum heitbaum commented Dec 9, 2024

PLEASE NOTE the following text from the iperf3 license. Submitting a
pull request to the iperf3 repository constitutes "[making]
Enhancements available...publicly":

You are under no obligation whatsoever to provide any bug fixes, patches, or
upgrades to the features, functionality or performance of the source code
("Enhancements") to anyone; however, if you choose to make your Enhancements
available either publicly, or directly to Lawrence Berkeley National
Laboratory, without imposing a separate written license agreement for such
Enhancements, then you hereby grant the following license: a non-exclusive,
royalty-free perpetual license to install, use, modify, prepare derivative
works, incorporate into other computer software, distribute, and sublicense
such enhancements or derivative works thereof, in binary and source code form.

The complete iperf3 license is available in the LICENSE file in the
top directory of the iperf3 source tree.

  • Version of iperf3 (or development branch, such as master or
    3.1-STABLE) to which this pull request applies: master and 3.17.1

  • Issues fixed (if any): compile with gcc-15

  • Brief description of code changes (suitable for use as a commit message): update declarations to include types as required by gcc-15 and -std=c23

@bmah888
Copy link
Contributor

bmah888 commented Feb 7, 2025

Thanks for the PR, we'll take a look!

davidBar-On added a commit to davidBar-On/iperf that referenced this pull request Feb 8, 2025
coolshou pushed a commit to coolshou/iperf that referenced this pull request Mar 26, 2025
@bmah888 bmah888 linked an issue Apr 18, 2025 that may be closed by this pull request
@bmah888 bmah888 self-assigned this Apr 18, 2025
Copy link
Contributor

@bmah888 bmah888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, although my ability to test this is limited. Per #1838 (comment) would you know if this is the same fix that was applied to iperf 3.18-2 in the Debian package repository?

swlars pushed a commit that referenced this pull request Apr 25, 2025
@userdocs
Copy link

@userdocs
Copy link

@bmah888
Copy link
Contributor

bmah888 commented May 2, 2025

Copy link
Contributor

@bmah888 bmah888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @heitbaum , or should I call you Mr. Bump? :-)

This looks good and it's now been tested by @userdocs , I will merge shortly.

@bmah888 bmah888 merged commit 7eeda4c into esnet:master May 2, 2025
3 checks passed
@userdocs
Copy link

userdocs commented May 2, 2025

Just to confirm it built fine on master with gcc15

https://github.com/userdocs/iperf3-static-test/actions/runs/14802833500

@bmah888
Copy link
Contributor

bmah888 commented May 2, 2025

@userdocs Thanks for the confirmation!

@heitbaum
Copy link
Contributor Author

heitbaum commented May 3, 2025

Thanks for the PR @heitbaum , or should I call you Mr. Bump? :-)

heitbaum is fine :-) as the LE distro packing lead, the team thought Mr.Bump suited, so the emoji stuck :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fails To Build From Source with GCC-15

3 participants