[2.0.0] Fix dropped SSL connection when buffer gets full. #4821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbedTLS requires repeated calls to mbedtls_ssl_write() whenever it returns MBEDTLS_ERR_SSL_WANT_READ or MBEDTLS_ERR_SSL_WANT_WRITE. this happens when the client sends data faster then the server or the connection can handle. Fixes: espressif/arduino-esp32#2494
everslick
changed the title
me-no-dev
reviewed
Feb 18, 2021
| return handle_error(ret); | ||
| } else{ | ||
| log_v("Returning with %d bytes written", ret); //for low level debug | ||
| while ((ret = mbedtls_ssl_write(&ssl_client->ssl_ctx, data, len)) <= 0) { |
Member
There was a problem hiding this comment.
I am a bit worried about such busy while loop. Add at least vTaskDelay(2); to ensure that task switching will work
Add vTaskDelay()
me-no-dev
pushed a commit
that referenced
this pull request
Mar 31, 2021
* Fix dropped SSL connection when buffer gets full. mbedTLS requires repeated calls to mbedtls_ssl_write() whenever it returns MBEDTLS_ERR_SSL_WANT_READ or MBEDTLS_ERR_SSL_WANT_WRITE. this happens when the client sends data faster then the server or the connection can handle. Fixes: #2494 * Update ssl_client.cpp Add vTaskDelay()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mbedTLS requires repeated calls to mbedtls_ssl_write() whenever it returns MBEDTLS_ERR_SSL_WANT_READ or MBEDTLS_ERR_SSL_WANT_WRITE. this happens when the client sends data faster then the server or the connection can handle.
Fixes: #2494