Skip to content

Serial reorganization code for RS-485 Mode, Flow Control Mode and Serial Mode #8687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SuGlider wants to merge 1 commit into from
Closed

Serial reorganization code for RS-485 Mode, Flow Control Mode and Serial Mode #8687

SuGlider wants to merge 1 commit into from

Conversation

@SuGlider
Copy link
Collaborator

@SuGlider SuGlider commented Oct 1, 2023

Description of Change

This PR makes RS-485 Mode and Flow Control Mode to be closer to the IDF HAL level in order to make it easier to maintain.
There is no change in its functionality.

It also moves SERIAL modes to HardwareSerial.h.

It helps the new Arduino IDE 2.0.x find the commentaries that allow Intellisense to display all the options for those functions.

Tests scenarios

ESP32 compilation testing.

Related links

None

@SuGlider SuGlider added the Peripheral: UART Related to the UART peripheral or its functionality. label Oct 1, 2023
@SuGlider SuGlider added this to the 3.0.0 milestone Oct 1, 2023
@SuGlider SuGlider self-assigned this Oct 1, 2023
@VojtechBartoska VojtechBartoska added the Status: Review needed Issue or PR is awaiting review label Oct 2, 2023
P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lucasssvaz
lucasssvaz approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@lucasssvaz lucasssvaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. LGTM.

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Oct 4, 2023
@SuGlider SuGlider changed the base branch from esp-idf-v5.1-libs to master October 5, 2023 12:30
@SuGlider SuGlider changed the base branch from master to esp-idf-v5.1-libs October 5, 2023 12:31
@SuGlider
Copy link
Collaborator Author

SuGlider commented Oct 5, 2023

Forced rebase master in #8718

@SuGlider SuGlider closed this Oct 5, 2023
@SuGlider SuGlider removed the Status: Pending Merge Pull Request is ready to be merged label Oct 5, 2023
@SuGlider SuGlider removed this from the 3.0.0 milestone Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucasssvaz lucasssvaz lucasssvaz approved these changes

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

@me-no-dev me-no-dev Awaiting requested review from me-no-dev

Assignees

@SuGlider SuGlider

Labels

Peripheral: UART Related to the UART peripheral or its functionality.

Projects

Arduino ESP32 Core Project Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SuGlider @lucasssvaz @P-R-O-C-H-Y @VojtechBartoska