Run Searches on separate task #2458
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmmarAbouZor
force-pushed
the
separate-searchers
branch
from
02e7af0 to
c9b307c
Compare
Member
Author
|
I've successfully run lint and test CI commands locally. The CI is failing because of issues related to GitHub Actions and not the changes in this PR |
AmmarAbouZor
force-pushed
the
separate-searchers
branch
3 times, most recently
from
d9eba07 to
8ac990c
Compare
itsmesamster
approved these changes
Dec 17, 2025
Collaborator
itsmesamster
left a comment
itsmesamster
left a comment
There was a problem hiding this comment.
Tested the changes, works fine on macOS arm64.
AmmarAbouZor
force-pushed
the
separate-searchers
branch
from
8ac990c to
540b254
Compare
Search request are CPU intensive and will block the async runtime especially if run with parsing in the same time (For example in big DLT files) causing the app to lag. Also I've added block_in_place in places where we expecting the code to block due to intense CPU processes.
AmmarAbouZor
force-pushed
the
separate-searchers
branch
from
540b254 to
e4ba1d3
Compare
Member
Author
|
Now it's running on CI checks as well after fixing the problem with caching |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the performance and the remove lagging in the UI in cases where search is active alongside with parsing incoming data by moving search processing CPU intensive blocks to another task to avoid blocking session state while these searches are done. Also, it uses
block_in_place()from tokio to avoid blocking the runtime on such CPU intensive tasks.These changes improve the performance up to 1.40x on parsing DLT files (500 MB) while a filter is applied:
These changes significantly reduce UI lag when filtering live data streams, such as process output or DLT over TCP/UDP