Skip to content

Issue 523: use file datatype to read strings #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotan merged 2 commits into from
Nov 16, 2021
Merged

Issue 523: use file datatype to read strings #525

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7aaa848
use file datatype to read strings
jkotan Nov 15, 2021
2a3f7b3
fix typo
jkotan Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/h5cpp/node/dataset.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1178,9 +1178,15 @@ void Dataset::write_reshape(const T &data,
template<typename T>
void Dataset::read(T &data,const property::DatasetTransferList &dtpl)
{
hdf5::datatype::DatatypeHolder mem_type_holder;
hdf5::dataspace::DataspaceHolder mem_space_holder(space_pool);
read_reshape(data, mem_type_holder.get(data), mem_space_holder.get(data), dtpl);
if(file_type_class == datatype::Class::String){
// in hdf5 1.12.1 UFT8 data cannot be read to an ASCII buffer
read_reshape(data, file_type, mem_space_holder.get(data), dtpl);
}
else {
hdf5::datatype::DatatypeHolder mem_type_holder;
read_reshape(data, mem_type_holder.get(data), mem_space_holder.get(data), dtpl);
}
}

template<typename T>
Expand Down