Conversation
yuelongyu
reviewed
Jan 7, 2022
Collaborator
yuelongyu
left a comment
yuelongyu
left a comment
There was a problem hiding this comment.
There are multiple places using
unsigned2signed or signed2unsigned
what's the difference between these methods and static_cast, can they be interchangeable?
|
|
||
| private: | ||
| datatype::Datatype file_type; | ||
| datatype::Datatype file_type_; |
Collaborator
There was a problem hiding this comment.
why does the variable name has to be changed?
Collaborator
Author
There was a problem hiding this comment.
I change the class variable because it is the same as a write method parameter and clang report it as a warning.
Collaborator
|
Looks good to me. Go for the merge. |
eugenwintersberger
approved these changes
Jan 8, 2022
Collaborator
eugenwintersberger
left a comment
eugenwintersberger
left a comment
There was a problem hiding this comment.
Looks good to me. Go for the merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It resolves #562 by fixing or ignoring clang warnings in macOS built.