Destroy Attributes's handle before its parent_link#662
Merged
jkotan merged 1 commit intoess-dmsc:masterfrom Dec 12, 2024
Merged
Conversation
Collaborator
|
I was just thinking, since it is hard to add proper unit tests maybe it would be good to add a small comment in the code about the issue in order no one revert it back. |
Member
I don't see the harm in adding a comment to make it less opaque, but I plan to see if a test can be created using |
Collaborator
|
I merge the current PR. We can add possible tests in a new PR |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out by @jkotan in a comment to the related PR #660, the same issue as described in #659 also appears for
Attributes:If an
Attributeinstance is kept around after the last reference to a file was dropped in client code, the order ofAttribute's members causes it to first try to close the underlying file before closing its own handle. If the file was opened with close degreeSemior the MPI-IO file driver was used, closing the file while theAttributeis still open is prohibited.This PR, therefore, applies the same fix to
Attributeas was applied toNodein #660; that is, it reorders the member ofAttributeto ensure that the handle is destroyed first, before attempting to close the file through destroying the link.