support 'regex' property when 'value' is null#396
Merged
michaelficarra merged 1 commit intoestools:masterfrom Jan 18, 2020
Merged
support 'regex' property when 'value' is null#396michaelficarra merged 1 commit intoestools:masterfrom
michaelficarra merged 1 commit intoestools:masterfrom
Conversation
fabiosantoscode
changed the title
regex property of a Literal when value is null
fabiosantoscode
changed the title
regex property of a Literal when value is null
fabiosantoscode
added a commit
to terser/terser
that referenced
this pull request
Sep 5, 2019
michaelficarra
approved these changes
Jan 18, 2020
michaelficarra
changed the title
bizob2828
pushed a commit
to Contrast-Security-OSS/escodegen
that referenced
this pull request
Apr 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there! Thank you very much for the work that's gone into this library :)
I come with a PR to fix an issue which came up while using escodegen to test Terser's mozilla AST generation.
According to the spec it's possible to set a
RegExpLiteral's value tonullsuch that the RegExp is fully defined in theregexproperty. We need to do this always in Terser since we print the estree serialized JSON to standard output, which is a medium that doesn't allow us to use actual regular expressions.To fix this, I just placed the logic that tests whether the Literal is a RegExpLiteral (IE checking for the regex property) above the other checks, which allows it to circumvent an early return of
'null'in this case.Thanks! :D