Skip to content

Conversation

@ahrtr
Copy link
Member

@ahrtr ahrtr commented Nov 17, 2025

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@hakman
Copy link

hakman commented Nov 17, 2025

/lgtm

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.16%. Comparing base (91201b1) to head (3d9d151).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

see 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20936      +/-   ##
==========================================
- Coverage   69.21%   69.16%   -0.06%     
==========================================
  Files         422      422              
  Lines       34839    34839              
==========================================
- Hits        24115    24095      -20     
- Misses       9326     9339      +13     
- Partials     1398     1405       +7     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91201b1...3d9d151. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants