Skip to content

Cull clips/triggers/slicks out of PVS #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aciz wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Cull clips/triggers/slicks out of PVS #97

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
637b5ef
Cull clips/triggers/slicks out of PVS
Aciz Jun 4, 2024
b7427f8
C89 compliance
Aciz Jun 4, 2024
3a873e5
Add fallback in case mod does not set cg.cgameClientLerpOrigin
Aciz Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions src/client/cl_tc_vis.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,13 +480,31 @@ static qboolean CullFace(const visFace_t *face) {
}

static void draw(visBrushNode_t *brush, qhandle_t shader) {
vec3_t clientOrigin = { 0.0f, 0.0f, 0.0f };
frustum = re.GetFrustum();

// this should be set to cg.refdef.vieworg in cgame,
// but fallback to player origin in case a mod has removed the syscall that sets it
if (!VectorCompare(cl.cgameClientLerpOrigin, vec3_origin)) {
VectorCopy(cl.cgameClientLerpOrigin, clientOrigin);
} else if (cl.snap.valid) {
VectorCopy(cl.snap.ps.origin, clientOrigin);
clientOrigin[2] += (float)cl.snap.ps.viewheight;
}

while (brush) {
int i;
for (i = 0; i < brush->numFaces; ++i) {
if (CullFace(brush->faces + i)) continue;
if (CullFace(brush->faces + i)) {
continue;
}

if (!re.inPVS(clientOrigin, brush->faces->mins) && !re.inPVS(clientOrigin, brush->faces->maxs)) {
continue;
}

re.AddPolyToScene(shader, brush->faces[i].numVerts, brush->faces[i].verts);
}
brush = brush->next;
}
}
}