schema: validate schemas against meta-schemas#253
Conversation
|
Nice to add:
|
7e28cc4 to
50fc057
Compare
|
The note in previous comment has been fully addressed: switched to See https://github.com/eth-cscs/stackinator/actions/runs/16642216221/job/47094558980 for an example of failure. |
|
As soon as #252 gets merged, which fixes the schema reported as error in the previous CI run, this one can be reviewed and merged. |
bcumming
left a comment
There was a problem hiding this comment.
Thanks, just a few little fixes to stick with using uv for package management.
| - uses: actions/checkout@v3 | ||
| - name: Install uv | ||
| - name: Install Tools | ||
| uses: threeal/pipx-install-action@v1.0.0 |
There was a problem hiding this comment.
Using pipx to install uv is a little bit meta - uv is supposed to be a replacement for pipx.
Instead, you can use uvx to run check-jsonschema.
| errors=0 | ||
| for schema in `find stackinator/schema -type f -name "*.json"`; do | ||
| echo $schema | ||
| check-jsonschema --check-metaschema $schema |
There was a problem hiding this comment.
| check-jsonschema --check-metaschema $schema | |
| uvx check-jsonschema --check-metaschema $schema |
spackinconfig.yaml#252The idea behind this is to add a CI check that validates schemas against meta schemas, aiming at early catching small errors like #252.
Changelog:
pipxto install bothuvandcheck-jsonschemacheck-jsonschemato validate all schemas (json files) in stackiantor/schema directory