test(deps): pin oidc-provider to ^8.5 so the backend tests pass#136
Closed
JohnMcLear wants to merge 1 commit intomainfrom
Closed
test(deps): pin oidc-provider to ^8.5 so the backend tests pass#136JohnMcLear wants to merge 1 commit intomainfrom
JohnMcLear wants to merge 1 commit intomainfrom
Conversation
oidc-provider v8.8.x changed its /auth redirect behaviour in a way that doesn't match the test harness in static/tests/backend/oidc-provider.js (/auth returns a non-redirect status instead of 302/303 → /interaction/, so the test harness stalls and 90 login-flow assertions fail). Pin the dev-only dep to ^8.5 for now, which the current harness supports. A proper follow-up would update the harness to drive whatever new interaction flow v8.8+ uses. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
Author
|
Pinning to ^8.5.3 didn't change the behaviour — same 90 login-flow assertions still fail. The root cause is in how the harness ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backend CI has been failing with 90 login-flow assertions of the form "expected .../auth?... to start with .../interaction/". Root cause:
oidc-providerv8.8 changed the /auth endpoint's redirect behaviour — it no longer sends 302/303 → /interaction/ thatstatic/tests/backend/oidc-provider.jsrelies on. Pin the dev-only dep to^8.5to restore CI while a follow-up updates the harness.