Our API versioning system doesn't actually for different API versions

[JohnMcLear]

If I want a different method exposed on say api/1.2/getHTML to api/1.3/getHTML this is not currently possible

[nelsonsilva]

How about changing APIHandler to check for the existence of api.version[apiVersion][functionName] ?
This way you use exports.version = {}; and add overrides as needed like exports.version["1.2.7"] = require(./api_1.2.7)

[JohnMcLear]

Any chance we can provide an example? #1514 is the problem I'm looking to solve.

[disy-mk]

Is the issue title still referencing to the problem or do you simply want to have feedback about the current status…

Are we looking for a good way to validate HTML?

You mean sth. like http://ericleads.com/h5validate/ ? Ot maybe this (https://github.com/peterjwest/html_validator) would be a something to start with?

[JohnMcLear]

@disy-mk I'm referencing the problem

[nelsonsilva]

@JohnMcLear Please checkout my pull request for a couple of different takes on this issue:
#1528

I think my last commit is the best approach for now.

Basically now you specify semver based rules when exporting API methods, so for the getHTML case you have:

API["*"].getHTML = ;
API[">=1.2.7"].getHTML = ;

In my pull request I just added a boolean flag to the getHTML function to decide whether to wrap the body or not and both of there rules delegate to your getHTML function.

With this in place I made API export a function:

module.exports = function(apiVersion) {
....
}

now we can just require the proper version using: require("../db/API")(apiVersion);

This functions goes through each of the semver rules and returns an object with all the functions that satisfy the requested version. I also added some cache to prevent having to recalculate this each time.

Hope this is something along what you're looking for.

[JohnMcLear]

Will do, back at things tomorrow hopefully.