User count shows total users on server, not on pad

[mullrich]

Is it a bug or a feature that on my etherpad installation (and on beta.etherpad.org) the user count shows the number of total users on the server rather that users on the current pad? Can I somehow change this behavior?

[JohnMcLear]

It's a bug, possibly related to #1454 @dmitryuv

[dmitryuv]

Typo! (facepalm)
I won't be able able to pull the fix for a few hours, but you can easily fix it:
https://github.com/dmitryuv/etherpad-lite/blob/feature/socketio-rooms/src/node/handler/PadMessageHandler.js#L1028
change to padIds.padId (without "s" on the end)

The naming of that var always confused me :)

[JohnMcLear]

will do

[JohnMcLear]

@mullrich please test #1545

[mullrich]

Solves it for me. Good job, guys!