How to test if an attribute is set at a range

Hi,

I want to find out if an attribute is set at a certain range (in my case the selected text).

There is a function editorInfo.ace_getAttributeOnSelection(attributeName) which name suggests that it should solve my problem but (seems to) return true only if the value of the attribute is true, and false otherwise.

How can I get the information if an attribute is set to any value? Or even better, get a list of all attributes that are set to any value on a specified range?

[JohnMcLear]

You can do it on the caret location/selected range such as this:
https://github.com/JohnMcLear/ep_font_size/blob/master/static/js/index.js#L63

This will return the value of the attribute IE if you want the font size of this selection it will return the integer associated with that font size, not just a boolean..

There isn't a way to get a list of all attributes on a specified range at current. I'd welcome this functionality though =)

That's the way I tried it, but got only boolean values, and looking at the source code of the function https://github.com/ether/etherpad-lite/blob/develop/src/static/js/ace2_inner.js#L2325 I also only found boolean returns.

[JohnMcLear]

Try console.log what the ep_font_size plugin gets, use it as a point of reference.

Oh actually.. Ignore that..

Yea I check for every possible attribute.. ;\ So yea it only returns a boolean! Apologies for the confusion

The ep_font_size plugin uses only boolean values for attributes (like fs12=true) so it is not affected by the problem.

[JohnMcLear]

I'd agree that hooks such as getAttributeValueOnSelection and getAttributesOnSelection would be useful if you wanna craft those in?

For a given position it turned out to be not as difficult to implement as suspected. So I added the function to the AttributeManager and created a pull request.

But for a range, after thinking about it, I am not yet sure, what a function should reasonably return if the selected range overlaps attributes. So maybe I come back to this point later.

[JohnMcLear]

Cool thanks :)