Changset.splitAttributionLines assumes a new line at the end of the string when there are new lines in the op

[pdobrev]

https://github.com/Pita/etherpad-lite/blob/master/node/utils/Changeset.js#L1166

splitAttributionLines assumes that if there's one new line in a given op, it will be at the end of the string and will add it as a separate attribution line.

For example, if you have the following op in a changeset:
Line1\n_some text_

it will get pushed as one attribution line, instead of adding Line1 as one line and some text to the next.

I am not sure if you can have this scenario is regular etherpad usage, probably not. I was using etherpad changesets and it's exportHtml functionality for a project of mine, when I bumped into this issue.

Changing the if block to the following fixed it for me:

if (numLines == 1) {
  var newlineEnd = text.indexOf('\n', pos) + 1;
  if (newlineEnd != pos + numChars) {
      // newline not at the end
      op.chars = newlineEnd - pos;
      op.lines = 1;
      appendOp(op);
      numChars -= op.chars;

      op.chars = numChars;
      op.lines = 0;
  } else {
      op.chars = numChars;
      op.lines = 1;
  }
}

[JohnMcLear]

This "might" be due to a bug in IE

Is it live anywhere we can test?

-----Original Message-----
From: Petar Dobrev [mailto:reply@reply.github.com]
Sent: 02 December 2011 08:57
To: John McLear
Subject: [etherpad-lite] Changset.splitAttributionLines assumes a new line at the end of the string when there are new lines in the op (#262)

https://github.com/Pita/etherpad-lite/blob/master/node/utils/Changeset.js#L1166

splitAttributionLines assumes that if there's one new line in a given op, it will be at the end of the string and will add it as a separate attribution line.

For example, if you have the following op in a changeset:
Line1\n_some text_

it will get pushed as one attribution line, instead of adding Line1 as one line and some text to the next.

I am not sure if you can have this scenario is regular etherpad usage, probably not. I was using etherpad changesets and it's exportHtml functionality for a project of mine, when I bumped into this issue.

Changing the if block to the following fixed it for me:

if (numLines == 1) {
  var newlineEnd = text.indexOf('\n', pos) + 1;
  if (newlineEnd != pos + numChars) {
      // newline not at the end
      op.chars = newlineEnd - pos;
      op.lines = 1;
      appendOp(op);
      numChars -= op.chars;

      op.chars = numChars;
      op.lines = 0;
  } else {
      op.chars = numChars;
      op.lines = 1;
  }
}

---

Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/issues/262
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools

[Pita]

@johnyma22 he is not talking about client side code

@pdobrev We don't know much about the Changeset Library. We took it from the old Etherpad and looked at how they use it. Thats why I can't tell you if this part is a problem or not

[pdobrev]

@Pita I think the scenario I described does not happen in regular etherpad usage, that is, when the changesets come from the Etherpad editor. Since in my case I was creating the changesets "by hand" from other sources, I bumped into this problem, which I fixed as described above.

[Pita]

@pdobrev Can you come to the #etherpad-lite-dev irc channel and tell me how you created them by hand?

[pdobrev]

@Pita Sure, I'll swing by. Basically, I used Changeset.smartOpAssembler and Changeset.pack to create the changesets from other sources (text files in my case). That's why I can have the case I described above, which I think doesn't happen with Etherpad's smaller changesets.

Best regards,
Pear

[marcelklehr]

status?

[JohnMcLear]

Closing due to lack of activity.