Skip to content

Connection diagnostics don't work #4191

@webzwo0i

Description

@webzwo0i

Since d26df86 diagnostics from disconnects are POSTed to the wrong url. We listen to /ep/pad/connection-diagnostic-info in https://github.com/ether/etherpad-lite/blob/develop/src/node/hooks/express/apicalls.js#L8 while that change made requests go to ep/pad/connection-diagnostic-info relative to path, so when you are in a pad at /p/abc diagnostics are sent to /p/ep/pad/connection-diagnostic-info

#2912 was the original pull request that introduced this behaviour, so I asked there if they can post their configuration.

We must decide, if we leave it up to ops to write configuration in their reverse proxy to handle all etherpad-specific paths (maybe include a section in the wiki for subdir-installations, ie https://yourhost.org/specific/path/for/etherpad) or if we include a setting in settings.json, eg "subdirectory", that makes same of the reverse proxy-path configs obsolete. socket.io and all javascripts/css files are relative already, but /jserror, /locales.json etc are served at a static path and we'd need to serve them at subdirectory+/jserror, subdirectory+/locales.json etc.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions