Fix for #1032 caused by pull-request 999#1059
Merged
JohnMcLear merged 2 commits intoether:developfrom Oct 11, 2012
Merged
Conversation
refact inInternationalComposition
fix Pita/etherpad-lite ether#1032 (International composition (e.g. Japanese Input))
JohnMcLear
added a commit
that referenced
this pull request
Oct 11, 2012
Fix for #1032 caused by pull-request 999
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #1032
The issue are happened at iframe-embed environment on firefox.
Caused by our inInternationalComposition fixes(https://github.com/Pita/etherpad-lite/pull/999).
Tested by the following browsers.(embed/non-embed)
Internet Explorer 9.0.8112.16421
Firefox 16
Firefox Aurora 17.0a2 2012-10-08
Google Chrome 22.0.1229.94
Google Chrome Beta 24.0.1290.1
see:
#1032
https://github.com/Pita/etherpad-lite/pull/999