Skip to content

Dont lose caret#1530

Merged
marcelklehr merged 5 commits intodevelopfrom
dont-lose-caret
Feb 21, 2013
Merged

Dont lose caret#1530
marcelklehr merged 5 commits intodevelopfrom
dont-lose-caret

Conversation

@JohnMcLear
Copy link
Copy Markdown
Member

To replicate, copy/paste data at bottom of pad then use up/left/down/right arrows to try to navigate the page.

@luto
Copy link
Copy Markdown
Contributor

luto commented Feb 18, 2013

The scrolling lags behind the actual caret movement for me, when the caret is above the page everything stays like it was for ~500ms, and then the page jumps up two lines, which confused me a bit..

@JohnMcLear
Copy link
Copy Markdown
Member Author

@mluto any chance of a video or screen recording?

@luto
Copy link
Copy Markdown
Contributor

luto commented Feb 18, 2013

@JohnMcLear
Copy link
Copy Markdown
Member Author

Well this lag is unavoidable as far as I can tell. We basically have to detect the bug then act if we find it. Also note that be behavior is different if you use up/down, please test that further and let me know if you prefer it or not.

@luto
Copy link
Copy Markdown
Contributor

luto commented Feb 18, 2013

As stated in IRC I don't like the new difference between up and down. I think that the arrow keys should execute the same action for one axis. :)

@JohnMcLear
Copy link
Copy Markdown
Member Author

done

@marcelklehr
Copy link
Copy Markdown
Contributor

This pull request cannot be automatically merged.

:)

@JohnMcLear
Copy link
Copy Markdown
Member Author

ready @marcelklehr

marcelklehr added a commit that referenced this pull request Feb 21, 2013
@marcelklehr marcelklehr merged commit 654175d into develop Feb 21, 2013
@Gared Gared deleted the dont-lose-caret branch December 26, 2014 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants