Skip to content

Added default Chinese translation#2029

Closed
nicolaasmatthijs wants to merge 1 commit intoether:developfrom
nicolaasmatthijs:defaultChinese
Closed

Added default Chinese translation#2029
nicolaasmatthijs wants to merge 1 commit intoether:developfrom
nicolaasmatthijs:defaultChinese

Conversation

@nicolaasmatthijs
Copy link
Copy Markdown

Our application integrates with Etherpad and will set Etherpad's locale to be the same as the one set in our application. However, the name of the Chinese translation file is not predictable compared to the other ones. Therefore, I'm adding a default Chinese locale file to the list of available locales.

@JohnMcLear
Copy link
Copy Markdown
Member

I'm not sure how this will interact with translatewiki cc @marcelklehr and @siebrand

@marcelklehr
Copy link
Copy Markdown
Contributor

Could you specify "not predictable"? If something doesn't work as
expected that could simply be a bug.

@nicolaasmatthijs
Copy link
Copy Markdown
Author

@marcelklehr : Our application uses the standard language_country locale format (e.g. en_GB, nl_NL, etc.). Based on the locale set by the user in our application, we automatically specify which languages Etherpad needs to be shown in. This is done by taking the first part of that locale code (e.g. en, nl, etc.). Unfortunately, Chinese is the only one for which that doesn't work, as zh doesn't exist.

@marcelklehr
Copy link
Copy Markdown
Contributor

We have fallbacks, but only from say 'zh-hans' to 'zh', not the other
way around.. Might be worth adding that, though. I'm open to that.

What do you think? If there's a consensus I'll happily add this.

@nicolaasmatthijs
Copy link
Copy Markdown
Author

+1. Being able to fall back from zh-hans to zh would be very useful.

@marcelklehr
Copy link
Copy Markdown
Contributor

Actually, I meant it the other way around. xx-foo already falls back
to xx, if the former doesn't exist. I was proposing a fallback from
xx to xx-<mmh>*, if xx doesn't exist

(* yea well, to what exactly..)

@nicolaasmatthijs
Copy link
Copy Markdown
Author

Sorry, that is what I meant as well. The logical one to fall back to would probably be zh-hans.

@marcelklehr
Copy link
Copy Markdown
Contributor

So, for this redirect to work for all languages, we can either use the first available or the alphabetically first lang as a redirect or we can define default redirects for all languages. I like alphabetical order ;)

@nicolaasmatthijs
Copy link
Copy Markdown
Author

The alphabetical approach sounds more straightforward

@ghost ghost assigned marcelklehr Dec 29, 2013
marcelklehr added a commit that referenced this pull request Dec 30, 2013
marcelklehr added a commit that referenced this pull request Dec 30, 2013
@marcelklehr
Copy link
Copy Markdown
Contributor

ok, please test #2052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants