mozilla bug 844796 - use node crypto module for randomString#2059
Merged
JohnMcLear merged 1 commit intoether:developfrom Jan 15, 2014
Merged
Conversation
Member
|
Cheers |
JohnMcLear
added a commit
that referenced
this pull request
Jan 15, 2014
mozilla bug 844796 - use node crypto module for randomString
Contributor
|
Nice. I'd leave the length parameter in, though.. Is there a reason why |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
randomString()cryptographically secure.I tried to modify the copy of this in
src/static/js/pad_utils.jsas well, but apparently that is used on the client side and thecryptomodule is not available there. I need to figure out exactly what this is used for on the client.