Trigger renumbering when deleting (via cut) the first item of a list#2533
Merged
JohnMcLear merged 1 commit intoether:developfrom Feb 27, 2015
Merged
Trigger renumbering when deleting (via cut) the first item of a list#2533JohnMcLear merged 1 commit intoether:developfrom
JohnMcLear merged 1 commit intoether:developfrom
Conversation
Member
|
Wow this is crazy clean.. Didn't expect this.. Does it work on pad "viewers" as well as the authors screen? |
Contributor
Author
|
@JohnMcLear Yep, seems to work fine for both the author and viewers immediately. |
Member
|
Wow excellent! I will give it a test.. |
JohnMcLear
added a commit
that referenced
this pull request
Feb 27, 2015
Trigger renumbering when deleting (via cut) the first item of a list
Member
|
Hrm, the caret appears to jump now to the last line on delete, are you seeing that? |
Contributor
Author
|
No, don't think I can reproduce that -- is it easy for you to share a screencast? It's a little weird to call doDeleteKey() when no key was pressed down, so it might be related to that, but I wasn't able to find any misbehavior with it here. |
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2514.