Pass through the "item" parameter to registerAceCommand callbacks.#2929
Merged
lpagliari merged 1 commit intoether:developfrom Dec 13, 2016
Merged
Pass through the "item" parameter to registerAceCommand callbacks.#2929lpagliari merged 1 commit intoether:developfrom
lpagliari merged 1 commit intoether:developfrom
Conversation
xavidotron
force-pushed
the
develop
branch
2 times, most recently
from
6f6be69 to
56b851a
Compare
Contributor
Author
|
Any chance of getting this pull request looked at? |
Member
|
I think this should be finde. What do you think @lpagliari |
Contributor
|
Yep, looks good to me. Sorry, @xavidotron , for taking so long. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing through the item parameter makes it easier to have one registerAceCommand callback that handles multiple toolbar items in a plugin and makes the interface more similar between registerCommand() and registerAceCommand().