extend attributesonselection method#2940
Merged
JohnMcLear merged 2 commits intodevelopfrom Apr 5, 2016
Merged
Conversation
| if(isNotSelection){ | ||
| if(prevChar){ | ||
| // If it's not the start of the line | ||
| if(rep.selStart[1] !== 0){ |
Contributor
There was a problem hiding this comment.
What if line has line attribute (which makes it start with "*")? Is that ok to look the attributes there, or should you look the attributes at 2nd char on line text?
Member
Author
There was a problem hiding this comment.
Hrm, would be interesting to try, in through it should try to put rep.selStart[1] as -1 in that instance which is not ideal :P
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready to test and hopefully merge