[fix] Do not show a 'pad deleted' message when pad is copied#3185
Closed
lpagliari wants to merge 1 commit intoether:developfrom
Closed
[fix] Do not show a 'pad deleted' message when pad is copied#3185lpagliari wants to merge 1 commit intoether:developfrom
lpagliari wants to merge 1 commit intoether:developfrom
Conversation
Message should be shown when pad is deleted or moved, not when it is copied. Fix ether#3183
lpagliari
added a commit
to joassouza/etherpad-lite
that referenced
this pull request
May 5, 2017
This commit applies the fix for bug showing 'pad deleted' message when pad is duplicated.
Member
|
Has merge conflicts :) Please resolve. |
Contributor
|
@lpagliari, from a quick check it seems that 187e519 already reverted this change. Should we close this pull request? |
Contributor
Author
|
Crap! Yeah, @muxator , you're right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Message should be shown when pad is deleted or moved, not when it is copied.
Tests performed:
Fix #3183