Conversation
JohnMcLear
commented
Mar 12, 2020
|
|
||
| return _.map(this.buttons, function (btn) { | ||
| return btn.render(); | ||
| if(btn) return btn.render(); |
Member
Author
There was a problem hiding this comment.
This is probably not needed.
JohnMcLear
commented
Mar 12, 2020
|
|
||
| ButtonsGroup.prototype.render = function () { | ||
| if (this.buttons.length == 1) { | ||
| if (this.buttons && this.buttons.length == 1) { |
Member
Author
There was a problem hiding this comment.
Again maybe not needed but maybe worth having just for some weirdness
Member
Author
|
Any reason we can't merge @muxator ? |
Contributor
|
Sure we can merge it. If possible, next time please do a PR from a personal fork, so it can eventually be reworked without interfering with the main repo. Or directly commit to develop if you think there is no need for review. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3707
Also reports the error to the server admin / plugin dev via console.warn.
I can't see any security considerations here but haven't done thorough testing.