Show chat fix - Ready for review/merge @muxator#3715
Closed
JohnMcLear wants to merge 12 commits intoether:developfrom
Closed
Show chat fix - Ready for review/merge @muxator#3715JohnMcLear wants to merge 12 commits intoether:developfrom
JohnMcLear wants to merge 12 commits intoether:developfrom
Conversation
Member
Author
|
Bump @muxator |
Updating
JohnMcLear
changed the title
Contributor
|
Is this still WIP? |
Member
Author
|
Yes. I want full test coverage. 24 hours ETA. |
JohnMcLear
changed the title
Contributor
|
What about the test coverage here? Still WIP? |
Member
Author
|
Sorry I should have said, yeah it's test covered. |
Contributor
|
Ok |
muxator
force-pushed
the
showChatFix
branch
2 times, most recently
from
99107d3 to
d9f7cb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3541
I'm wondering if we can have test coverage for this...?