Fix duplicated iframes after importing text in a pad#3925
Merged
muxator merged 2 commits intoether:developfrom Apr 26, 2020
Merged
Fix duplicated iframes after importing text in a pad#3925muxator merged 2 commits intoether:developfrom
muxator merged 2 commits intoether:developfrom
Conversation
This was referenced Apr 23, 2020
Closed
Contributor
|
This becomes part of #3915, correct? (I'll do in the weekend) |
Member
Author
|
Yea but I kept it separate because it was something that was historically broken and someone might want to cherry pick it into a previous version... Also it keeps things clean. |
Contributor
|
Ok |
JohnMcLear
changed the title
This is an old bug: after an import there were always two iframes with duplicated content, and the last one was simply on top of the old one. This bug was there since forever, and became evident when the layout was migrated to Flexbox.
muxator
changed the title
muxator
force-pushed
the
dont-duplicate-ace-outer-on-import
branch
from
fb67144 to
0350811
Compare
Contributor
|
For documentation's sake: this is an old bug in It was not evident with the old absolutely positioned layout, but after moving to flexbox it stood out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.