Skip to content

doc: remove old vendorized marked module and replace with 0.8.2#3929

Merged
muxator merged 1 commit intoether:developfrom
muxator:feature/update-marked
Apr 24, 2020
Merged

doc: remove old vendorized marked module and replace with 0.8.2#3929
muxator merged 1 commit intoether:developfrom
muxator:feature/update-marked

Conversation

@muxator
Copy link
Copy Markdown
Contributor

@muxator muxator commented Apr 24, 2020

This change is needed because in 1.8.3 we are going to introduce Markdown tables in the documentation (#3873 and #3921), and the old marked version did not support generating them.

Instead of committing the marked source code here, we live install from npm if needed via the Makefile.

n.b.: at the time of this change, marked latest version is 1.0.0, released a few days ago. I am updating to the version immediately before that (0.8.2), because in 1.0.0 the hyperlinks in the Table of Contents do not work (probably a bug in that version).

This change is needed because in 1.8.3 we are going to introduce Markdown tables
in the documentation (#3873 and #3921), and the old marked version did not
support generating them.

Instead of committing the marked source code here, we live install from npm if
needed via the Makefile.

n.b.: at the time of this change, marked latest version is 1.0.0, released a few
      days ago. I am updating to the version immediately before that (0.8.2),
      because in 1.0.0 the hyperlinks in the Table of Contents do not work
      (probably a bug in that version).
@muxator muxator added the docs label Apr 24, 2020
@muxator muxator added this to the 1.8.3 milestone Apr 24, 2020
@muxator muxator mentioned this pull request Apr 24, 2020
1 task
@muxator muxator merged commit db77302 into ether:develop Apr 24, 2020
@muxator muxator deleted the feature/update-marked branch April 26, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant